[BEAM-2610] upgrade to version 2.2.0 #3553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes #3394
This closes #3381
Transform expansion and translation for the involved primitive transforms. Of course, the current PR will only work after the respective Dataflow worker and backend changes are released.
If a Write operation in streaming requests runner-determined sharding, make the Dataflow runner default to maxNumWorkers * 2 shards.
Previously CallablePTransform was being used both as the factory and the transform itself, which could result in state getting carried between pipelines.
|
R: @takidau @xumingming |
|
Can you please stage the second PR as a branch that builds on this one first? I don't want the branch to be left in a broken state for too long. |
|
I create a draft PR #3554 there, as far as I know that's just a simple version change. |
|
Thanks, merging. |
|
Merged. |
|
Thanks! |
Respect non-retryable error codes from Datastore. Add unit tests to check that retryable errors are retried.
|
@takidau I'm afraid the merge of this task has some issues, or maybe I'm using the wrong method. --I tried to create a pull request from DSL_SQL based on Master, in web page, and it's shown as 'Can’t automatically merge'. I see lots of files from master branch will be listed. |
|
Changes Unknown when pulling e8c5574 on master into ** on DSL_SQL**. |
mingmxu
pushed a commit
to mingmxu/beam
that referenced
this pull request
Jul 19, 2017
Revert "[BEAM-2610] This closes apache#3553"
mingmxu
pushed a commit
to mingmxu/beam
that referenced
this pull request
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in task BEAM-2610, this is the first PR to do the job. Feel free to merge it if no mis-operation during creating the PR as any issues are supposed to be fixed in the second PR.
Btw, the failure is expected as dsl/sql is still using
2.1.0-SNAPSHOT, and be fixed in PR 2