[BEAM-2862] Add PTransform overrides specific to execution of StatefulDoFns over the Fn API using the DataflowRunner. #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lDoFns over the Fn API using the DataflowRunner.
|
R: @tgroh |
tgroh
approved these changes
Sep 11, 2017
| } | ||
|
|
||
| @Test | ||
| @Ignore("TODO: Add support for user state in a ParDo.Multi once PTransformMatcher exposes " |
| * A key preserving {@link DoFn} that expands the output of a GBK {@code KV<K, Iterable<V>>} into | ||
| * individual KVs. | ||
| */ | ||
| static class ExpandGbkFn<K, V> |
There was a problem hiding this comment.
I almost want to move this to Flatten, e.g. Flatten.valueIterables(), but I think that generally runner authors are the only ones who would use it.
However, it could find a home in runners-core-construction if not in the core SDK.
There was a problem hiding this comment.
I'm sure once we have key preserving as a piece of info available, we will want to expose these for re-use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.