[BEAM-3738] Enable py3 lint

[aaltay]

Since we verified that Jenkins workers have python3 installed (https://issues.apache.org/jira/browse/BEAM-3671) we should be able to enable py3 lint.

R: @alanmyrvold

[aaltay]

R: @holdenk

[cclauss]

What version of Python 3 are we testing under? The other test blocks do python --version and pip --version but the lint_py3 one does not.

[aaltay]

@cclauss Good catch. I believe we have 3.4.3 version based on (https://issues.apache.org/jira/browse/BEAM-3671). I will update tox.ini to print version for this use too.

[aaltay]

Updated, but I think we need to think about one more case. It turned out that printing the version was a good idea, because tox was defaulting to python2. Running it with python3 uncovered an issue: setup.py has python_requires='>=2.7,<3.0', which makes tox fail. We can remove that but we are not py3 compatible yet.

[cclauss]

We could reduce our exposure by making it python_requires='>=2.7,<=3.4' because 95% of users will no longer be using Python 3.4 when the current Python is 3.6.4 and 3.7 is in beta.

Or reduce our exposure even more by making it python_requires='>=2.7,==3.4.3' because that is the exact Python 3 version that we have and the current Python 3.4 is version 3.4.7.

[holdenk]

So @cclauss I don't think that limiting to 3.4.3 is great since someone might read it and then just try to use 3.4.3. Personally I'd use an env variable to (e.g. LINTING) and in linting have a different requirement. We also probably want folks to be able to run tox on their own machines since its in the guide.

But I like the direction of selectively unblocking setup.py for testing/linting so that we more easily track our progress and avoid regressions.

[holdenk]

@aaltay what are your thoughts?

[aaltay]

I have not had a chance to work on this after the my previous comment. I like the idea of using an environment variable.

[udim]

I've created #4877, which should include the changes here as well.

[aaltay]

Thank you @udim. Closing this PR in favor of #4877.

[robertwb]

+1 to using an environment variable, much better than falsely claiming 3.0-3.4 support.

…

On Fri, Mar 16, 2018 at 5:23 PM Ahmet Altay ***@***.***> wrote: Closed #4801 <#4801>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4801 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAdqgVMb52r6lbtbWDBZnCrWskN-x0EDks5tfFeOgaJpZM4Sd4mI> .