[BEAM-3804] Build Go SDK container with gradle #4833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @lukecwik |
lukecwik
requested changes
Mar 8, 2018
sdks/go/container/build.gradle
Outdated
| } | ||
|
|
||
| golang { | ||
| packagePath = 'github.com/apache/beam/sdks/python/boot' |
There was a problem hiding this comment.
This doesn't seem like the appropriate package path.
There was a problem hiding this comment.
Fixed the typo for clarity. This package path is not actually used, because we're building a main package.
lukecwik
reviewed
Mar 8, 2018
| } | ||
|
|
||
| docker { | ||
| String repositoryRoot |
There was a problem hiding this comment.
It seems like we could make this part of the applyDockerNature as it seems duplicated amongst the three docker container build.gradle files.
There was a problem hiding this comment.
Agreed. I'll try to spend some time on this on Gradle fixit day.
|
Thanks @lukecwik. PTAL |
lukecwik
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code is similar to how the Python and Java containers are built.