Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1251] Change unicode --> six.text_type for Python 3 - again #4835

Merged
merged 1 commit into from Mar 9, 2018

Conversation

@cclauss
Copy link
Contributor

commented Mar 8, 2018

unicode was removed in Python 3 because all str are Unicode so this PR is changing one instance of unicode to six.text_type.

DESCRIPTION HERE


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
@cclauss

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2018

@aaltay

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2018

@cclauss I think there was a Jenkins wide issue and nothing specific to this test was wrong. I could not find anything in the logs. And when I compare with the tests before and after, I noticed additional fields added (" Git Build Data") to the Jenkins UI for the tests ran after. I also checked other test suites, all seems to have failed tests at about same time. (cc: @alanmyrvold in case Alan knows something about this.)

Please retry running the test.

@holdenk

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2018

So I did a live code review of an Apache Spark PR today, would you @cclauss be OK with me doing a live review of this (or one of your other PRs)? Not a committer on this project but I also want to show folks how they can help review in projects where they aren't committers.

If not no worries.

@cclauss

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2018

Sure... No problems.

@aaltay

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2018

LGTM.

cc: @udim

@aaltay aaltay merged commit 7605bcb into apache:master Mar 9, 2018

5 checks passed

Jenkins: ./gradlew --info --continue --rerun-tasks :goPreCommit SUCCESS
Details
Jenkins: ./gradlew --info --continue --rerun-tasks :javaPreCommit SUCCESS
Details
Jenkins: mvn clean install -pl sdks/go -am -amd SUCCESS
Details
Jenkins: mvn clean install -pl sdks/java/core,runners/direct-java,sdks/java/fn-execution -am -amd SUCCESS
Details
Jenkins: mvn clean install -pl sdks/python -am -amd SUCCESS
Details

@cclauss cclauss deleted the cclauss:unicode-to-six.text_type-again branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.