Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined names: import MetricKey, MetricName #5310

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

cclauss
Copy link

@cclauss cclauss commented May 8, 2018

As mentioned at 582fcea#r28136702 these two variables are undefined names in this context. This PR imports them to resolve the undefined names.

DESCRIPTION HERE


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run ./gradlew build to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

As mentioned at apache@582fcea#r28136702 these two variables are undefined names in this context.  This PR imports them to resolve the undefined names.
@lukecwik
Copy link
Member

lukecwik commented Jun 1, 2018

Thanks.

@lukecwik lukecwik merged commit 4a188ff into apache:master Jun 1, 2018
@cclauss cclauss deleted the patch-1 branch June 1, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants