Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-4536] Remove with_attributes keyword from ReadFromPubSub. #5607

Merged
merged 1 commit into from
Jun 14, 2018

Conversation

udim
Copy link
Member

@udim udim commented Jun 12, 2018

Cherrypick for 2.5.0


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

@udim
Copy link
Member Author

udim commented Jun 12, 2018

R: @jbonofre

@jbonofre jbonofre self-requested a review June 12, 2018 19:30
@jbonofre
Copy link
Member

Same issue on this PR: java.lang.IllegalStateException: sendHeaders has already been called.

@boyuanzz
Copy link
Contributor

retest this please

@udim
Copy link
Member Author

udim commented Jun 13, 2018

Looking at java breakage.

BEAM-4536: with_attributes is broken for Dataflow. This commit removes
the feature for the 2.5.0 release of Beam.
@boyuanzz
Copy link
Contributor

Run Java PreCommit

@udim
Copy link
Member Author

udim commented Jun 13, 2018

retest this please

@boyuanzz
Copy link
Contributor

Run Java PreCommit

@udim
Copy link
Member Author

udim commented Jun 13, 2018

@jbonofre ./gradlew :beam-runners-direct-java:test was broken for me on my local machine. I did a git pull --rebase and that fixed it. I then pushed the commit again in the hopes that it'd fix the precommit somehow, however now #5611 has disabled running Java precommits.
I've asked @swegner to revert #5611 so we can verify that Java precommits are not broken.

@udim
Copy link
Member Author

udim commented Jun 13, 2018

Run Java PreCommit

@pabloem
Copy link
Member

pabloem commented Jun 13, 2018

I triggered a build on the release branch itself, and it failed:
https://builds.apache.org/job/beam_PreCommit_Java_GradleBuild/6441/consoleFull

@swegner
Copy link
Contributor

swegner commented Jun 13, 2018

FYI, the failing test org.apache.beam.runners.direct.portable.ReferenceRunnerTest.pipelineExecution, I recognize from other PRs as being flaky (history). This PR seems unrelated and seems unlikely that it caused the regression.

/cc @reuvenlax @tgroh as the owners for this test.

@jbonofre jbonofre merged commit 8f65a68 into apache:release-2.5.0 Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants