-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-4536] Remove with_attributes keyword from ReadFromPubSub. #5607
Conversation
R: @jbonofre |
Same issue on this PR: |
retest this please |
Looking at java breakage. |
BEAM-4536: with_attributes is broken for Dataflow. This commit removes the feature for the 2.5.0 release of Beam.
Run Java PreCommit |
retest this please |
Run Java PreCommit |
@jbonofre |
Run Java PreCommit |
I triggered a build on the release branch itself, and it failed: |
FYI, the failing test /cc @reuvenlax @tgroh as the owners for this test. |
Cherrypick for 2.5.0
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username
) to look at it.