[BEAM-4150] Extract IO coders from the RemoteGrpcPort. #5700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukecwik
requested changes
Jun 21, 2018
| else: | ||
| raise NotImplementedError | ||
| data_spec = beam_fn_api_pb2.RemoteGrpcPort(coder_id=coder_id) |
There was a problem hiding this comment.
The PCollection coder doesn't have the windowing information, you'll need to construct one using the windowing strategies coder otherwise you'll be sending the raw coder across.
There was a problem hiding this comment.
In this runner, it actually does. (This doesn't fully fix BEAM-4150, just the worker side and enough of the runner to be compatible.)
|
Run Python PostCommit |
1 similar comment
|
Run Python PostCommit |
lukecwik
approved these changes
Jun 21, 2018
|
Run Python PostCommit |
charlesccychen
pushed a commit
to charlesccychen/beam
that referenced
this pull request
Jul 26, 2018
…m the RemoteGrpcPort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.