Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-5620] rename assertItemsEqual to assertCountEqual for PY3 compatibility #6599

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

Fematich
Copy link
Contributor

@Fematich Fematich commented Oct 7, 2018

Replaced all assertItemsEqual by assigning it to assertCountEqual on Python 2, as discussed in BEAM-5620 and illustrated in

I have added def setUpClass(cls) if it wasn't available (only setUp was in most cases), so that it shouldn't be rerun for every test of the class.

This is is part of a series of PRs with goal to make Apache Beam PY3 compatible. The proposal with the outlined approach has been documented here: https://s.apache.org/beam-python-3

@tvalentyn @manuzhang @charlesccychen @aaltay @splovyt @Juta

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@Fematich Fematich changed the title [BEAM-5620] rename assertItemsEqual to assertCounEqual for PY3 compatibility [BEAM-5620] rename assertItemsEqual to assertCountEqual for PY3 compatibility Oct 7, 2018
@tvalentyn
Copy link
Contributor

LGTM. Thank you, @Fematich.

@aaltay aaltay merged commit 9c8d3cd into apache:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants