[BEAM-6748] Account for synchronization interval when estimating amount of blocks in generated Avro test file. #8015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt of blocks in generated Avro test file.
|
R: @chamikaramj |
chamikaramj
reviewed
Mar 11, 2019
|
|
||
| # When reading records of the first block, range_tracker.split_points() | ||
| # should return (0, iobase.RangeTracker.SPLIT_POINTS_UNKNOWN) | ||
| self.assertEquals( | ||
| self.assertEqual( |
There was a problem hiding this comment.
Please add an assertion for num_blocks > 1 here.
There was a problem hiding this comment.
Done, thank you!
|
LGTM. Thanks. |
|
Thanks for review & merge, @chamikaramj . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Python 3 there are a few test failures, because the size avro.datafile.SYNC_INTERVAL is different:
https://github.com/apache/avro/blob/f173ae8d690b5f90e8cc5899b654762a9d11e17d/lang/py/src/avro/datafile.py#L39
https://github.com/apache/avro/blob/f173ae8d690b5f90e8cc5899b654762a9d11e17d/lang/py3/avro/datafile.py#L57
This PR fixes it.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.