Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7675] Unify Gradle test configuration across Py2 and Py3 #9183

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

markflyhigh
Copy link
Contributor

@markflyhigh markflyhigh commented Jul 29, 2019

Unify Python Gradle test configuration so that all Python tests are located in right directory of :sdks:python:test-suites.

  • Move all test related Gradle tasks from sdks/python/build.gradle to :sdks:python:test-suties. Those tests are placed in py2 subdirectory based on type/runner. sdks/python/build.gradle should only holds non-testing/analysis tasks.
  • Create py2 subdirectory for each python test-suite.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@markflyhigh
Copy link
Contributor Author

run seed job

@markflyhigh
Copy link
Contributor Author

Run Portable_Python PreCommit

@markflyhigh
Copy link
Contributor Author

Run Python_PVR_Flink PreCommit

@markflyhigh
Copy link
Contributor Author

Run Python27 WordCountIT Performance Test

@markflyhigh
Copy link
Contributor Author

Run Python MongoDBIO_IT

@markflyhigh
Copy link
Contributor Author

Run Python Spark ValidatesRunner

@markflyhigh
Copy link
Contributor Author

Run Python 2 PostCommit

@markflyhigh
Copy link
Contributor Author

markflyhigh commented Jul 29, 2019

Following affected Jenkins tests are passing:

Python Spark ValidatesRunner Tests is broken for a while due to dependency upgrade (Numpy 1.17.0 requires python3.5 and above). I may not be able to make it pass in this PR.

I'll go ahead and quick fix Portable_Python PreCommit.

@markflyhigh
Copy link
Contributor Author

run seed job

@markflyhigh
Copy link
Contributor Author

Run Python_PVR_Flink PreCommit

@markflyhigh
Copy link
Contributor Author

Portable_Python PreCommit passed. All tests are done.

@markflyhigh
Copy link
Contributor Author

Please review: @tvalentyn
cc: @udim

Copy link
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as suites pass.

@tvalentyn
Copy link
Contributor

Thanks, @markflyhigh.

@markflyhigh
Copy link
Contributor Author

Thank you. I'll merge it.

@markflyhigh markflyhigh merged commit 0e60dfa into apache:master Jul 30, 2019
Hannah-Jiang pushed a commit to Hannah-Jiang/beam that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants