Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8165] Revert docker default root name #9588

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

Hannah-Jiang
Copy link
Contributor

@Hannah-Jiang Hannah-Jiang commented Sep 16, 2019

Use apachebeam only for sdk harness images.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@Hannah-Jiang Hannah-Jiang changed the title [WIP][BEAM-8165] Revert docker default root name [BEAM-8165] Revert docker default root name Sep 17, 2019
@Hannah-Jiang
Copy link
Contributor Author

R: @aaltay
Cc: @markflyhigh, we need to cherry pick this PR.

@aaltay
Copy link
Member

aaltay commented Sep 17, 2019

Could you add more information to here or the JIRA about:

  • What is happening here? When is docker-repository-root defined and when it is not?
  • What is it fixing?
  • Why do we use a mix of bintray and docker hub?

@Hannah-Jiang
Copy link
Contributor Author

Could you add more information to here or the JIRA about:

  • What is happening here? When is docker-repository-root defined and when it is not?
  • What is it fixing?
  • Why do we use a mix of bintray and docker hub?

I added a comment to the ticket.

@aaltay
Copy link
Member

aaltay commented Sep 17, 2019

LGTM. Thank you. After cherry pick let's clean up this 2 root thing.

@aaltay aaltay merged commit 85d6d38 into apache:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants