Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-4012. Update Adoptium repository settings for Debian 11 in bigtop_toolchain. #1185

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

sekikn
Copy link
Contributor

@sekikn sekikn commented Oct 13, 2023

Description of PR

Currently we're using AdoptOpenJDK 8 for Debian, but its repository has been moved. This PR updates its repository URL and package name.

How was this patch tested?

Ran sudo puppet apply --modulepath=/usr/share/puppet/modules:/path/to/bigtop -e "bigtop_toolchain::installer" on Debian 11 and ensured it was successful.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
  • Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Building bigtop-slaves image worked. Thanks, @sekikn .

@iwasakims iwasakims merged commit a80ccce into apache:master Dec 23, 2023
iwasakims pushed a commit that referenced this pull request Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants