BIGTOP-3978. Drop debian-10 support #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwasakims
reviewed
Dec 25, 2023
| @@ -267,7 +267,7 @@ Properties: | |||
| -Pmemory=[4g|8g|...] | |||
| -Pnum_instances=[NUM_INSTANCES] | |||
| -Pnexus=[NEXUS_URL] (NEXUS_URL is optional) | |||
| -POS=[centos-7|fedora-35|debian-10|ubuntu-18.04|opensuse-42.3|openeuler-22.03] | |||
| -POS=[centos-7|fedora-35|ubuntu-18.04|opensuse-42.3|openeuler-22.03] | |||
There was a problem hiding this comment.
Replacing it with debian-11 could be better than removing it. Since the description is outdated and not exhaustive, we can fix it in dedicated PR later.
There was a problem hiding this comment.
@iwasakims thanks for your advice, I will fix it
iwasakims
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Drop debian-10 support
How was this patch tested?
We can use following comand to test it
and it will be get a failure
that's what we expected.
For code changes: