Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record metadata store version somewhere #282

Closed
sijie opened this issue Jul 24, 2017 · 3 comments
Closed

Record metadata store version somewhere #282

sijie opened this issue Jul 24, 2017 · 3 comments

Comments

@sijie
Copy link
Member

sijie commented Jul 24, 2017

FEATURE REQUEST

  1. Please describe the feature you are requesting.

Address the TODO item in MSLedgerManagerFactory

    // load metadata store
    String msName = conf.getMetastoreImplClass();
    try {
        metastore = MetastoreFactory.createMetaStore(msName);

        // TODO: should record version in somewhere. e.g. ZooKeeper
        int msVersion = metastore.getVersion();
        metastore.init(conf, msVersion);
    } catch (Throwable t) {
        throw new IOException("Failed to initialize metastore " + msName + " : ", t);
    }
  1. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

nice-to-have

  1. Provide any additional detail on your proposed use case for this feature.

N/A

@sijie sijie added this to the 4.5.0 milestone Jul 24, 2017
@sijie sijie modified the milestones: 4.6.0, 4.5.0 Jul 24, 2017
@sijie sijie removed this from the 4.6.0 milestone Nov 16, 2017
@sijie
Copy link
Member Author

sijie commented Nov 16, 2017

removed the milestone, can revisit in 4.7

@ivankelly
Copy link
Contributor

@sijie Can we close this since we're planning to deprecate metadata store anyhow?

@ivankelly ivankelly added the triage/18-w11 Issue triage, 2018 week 11 label Mar 12, 2018
@sijie
Copy link
Member Author

sijie commented Mar 12, 2018

close the issue as "won't fix", since metadata store api is not used and will be replaced with metadata service api.

@sijie sijie closed this as completed Mar 12, 2018
athanatos pushed a commit to athanatos/bookkeeper that referenced this issue Jan 25, 2019
Author: Robert Evans <evans@yahoo-inc.com>

Reviewers: Michael Han <hanm@apache.org>, Mohammad Arshad <arshad@apache.org>

Closes apache#282 from revans2/ZOOKEEPER-1782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants