Update bookkeeper dependencies : netty/protobuf/grpc #1441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* The netty version in bookkeeper is a bit dated than the version in pulsar. Hence the grpc version is limited to the version that use same netty version. It causes issues at pulsar using bookkeeper, because pulsar has been using a newer version for longer time. This causes conflicts when pulsar client and grpc are used together without proper shading. *Solution* Upgrade netty/protobuf/grpc dependencies. - update netty from `4.1.12` to `4.1.22`, which is the one grpc is using and closer to the one that pulsar is using. - update grpc from `1.5.0` to `1.12.0`, which is using netty `4.1.22` and protobuf `3.5.1`. - update protobuf from `3.4.0` to `3.5.1` Related Issue: apache/pulsar#1844
jiazhai
approved these changes
May 25, 2018
eolivelli
approved these changes
May 25, 2018
|
@merlimat please review |
|
IGNORE IT CI |
sijie
added a commit
that referenced
this pull request
Jun 4, 2018
Descriptions of the changes in this PR: *Motivation* The netty version in bookkeeper is a bit dated than the version in pulsar. Hence the grpc version is limited to the version that use same netty version. It causes issues at pulsar using bookkeeper, because pulsar has been using a newer version for longer time. This causes conflicts when pulsar client and grpc are used together without proper shading. *Solution* Upgrade netty/protobuf/grpc dependencies. - update netty from `4.1.12` to `4.1.22`, which is the one grpc is using and closer to the one that pulsar is using. - update grpc from `1.5.0` to `1.12.0`, which is using netty `4.1.22` and protobuf `3.5.1`. - update protobuf from `3.4.0` to `3.5.1` Related Issue: apache/pulsar#1844 Author: Sijie Guo <sijie@apache.org> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Matteo Merli <mmerli@apache.org> This closes #1441 from sijie/bump_grpc_version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
The netty version in bookkeeper is a bit dated than the version in pulsar.
Hence the grpc version is limited to the version that use same netty version.
It causes issues at pulsar using bookkeeper, because pulsar has been using
a newer version for longer time. This causes conflicts when pulsar client and
grpc are used together without proper shading.
Solution
Upgrade netty/protobuf/grpc dependencies.
4.1.12to4.1.22, which is the one grpc is using and closer to the one that pulsar is using.1.5.0to1.12.0, which is using netty4.1.22and protobuf3.5.1.3.4.0to3.5.1Related Issue: apache/pulsar#1844