Allow to configure num of Netty IO threads in client and bookie #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Aug 18, 2018
I haven't tested the various numbers. Only scope for this PR is to allow flexibility to configure thread pool size. I might make sense to reduce the thread pool when there are other event loop thread pools running in same process. |
jvrao
approved these changes
Aug 18, 2018
sijie
approved these changes
Aug 20, 2018
|
run integration tests |
1 similar comment
|
run integration tests |
sijie
pushed a commit
that referenced
this pull request
Aug 21, 2018
Currently the number of IO threads for client and bookie are set to `2 * Runtime.getRuntime().availableProcessors()`. Added configuration options to tune it. Author: Matteo Merli <mmerli@apache.org> Author: Sijie Guo <guosijie@gmail.com> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>, Venkateswararao Jujjuri (JV) <None> This closes #1612 from merlimat/configure-io-threads (cherry picked from commit b9916d3) Signed-off-by: Sijie Guo <sijie@apache.org>
This was referenced Apr 2, 2022
zymap
pushed a commit
that referenced
this pull request
Apr 13, 2022
### Motivation #1612 this PR make the Netty io threads number configurable, but doesn't expose to the `bk_server.conf`. This parameter will be usually changed in performance tuning especially deploy this bookie on bare metal which have many cpus. For operation engineer who is unfamiliar with the source code will be hard to do performance tuning. ### Changes Expose this parameter configuration into `bk_server.conf` and website. And add more explanation about it.
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation apache#1612 this PR make the Netty io threads number configurable, but doesn't expose to the `bk_server.conf`. This parameter will be usually changed in performance tuning especially deploy this bookie on bare metal which have many cpus. For operation engineer who is unfamiliar with the source code will be hard to do performance tuning. ### Changes Expose this parameter configuration into `bk_server.conf` and website. And add more explanation about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the number of IO threads for client and bookie are set to
2 * Runtime.getRuntime().availableProcessors(). Added configuration options to tune it.