Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Add a perf tool for benchmarking bookkeeper #1697

Merged
merged 3 commits into from
Sep 25, 2018
Merged

Conversation

sijie
Copy link
Member

@sijie sijie commented Sep 25, 2018

Descriptions of the changes in this PR:

Motivation

when investigating performance on scanning entries in bookkeeper, it is hard to know what is the expectation of what kind of throughput that application can get. we need a perf tool to understand the baseline of performance that bookkeeper can provide.

Changes

this tool is following what pulsar perf tool is doing and using dlog library for evaluating the write and read throughput on bookkeeper using one (or a few) dlog streams.


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all
the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You
can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if
you are not sure, committers will help you:

  • [skip bookkeeper-server bookie tests]: skip testing org.apache.bookkeeper.bookie in bookkeeper-server module.
  • [skip bookkeeper-server client tests]: skip testing org.apache.bookkeeper.client in bookkeeper-server module.
  • [skip bookkeeper-server replication tests]: skip testing org.apache.bookkeeper.replication in bookkeeper-server module.
  • [skip bookkeeper-server tls tests]: skip testing org.apache.bookkeeper.tls in bookkeeper-server module.
  • [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.
  • [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.
  • [skip build java8]: skip build on java8. ONLY skip this when ONLY changing files under documentation under site.
  • [skip build java9]: skip build on java9. ONLY skip this when ONLY changing files under documentation under site.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

@sijie
Copy link
Member Author

sijie commented Sep 25, 2018

when helping @jerrypeng at looking into pulsar SQL performance, I wrote this tool which can be used for finding the throughput for writing and sequential reading that people can expect from a bookkeeper. it is actually very useful for perf purpose, so pushing this tool out here.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

+1

@sijie
Copy link
Member Author

sijie commented Sep 25, 2018

run integration tests

@sijie
Copy link
Member Author

sijie commented Sep 25, 2018

run integration tests

3 similar comments
@jiazhai
Copy link
Member

jiazhai commented Sep 25, 2018

run integration tests

@sijie
Copy link
Member Author

sijie commented Sep 25, 2018

run integration tests

@sijie
Copy link
Member Author

sijie commented Sep 25, 2018

run integration tests

@sijie
Copy link
Member Author

sijie commented Sep 25, 2018

IGNORE IT CI

@sijie sijie added this to the 4.9.0 milestone Sep 25, 2018
@sijie sijie merged commit c02e0fb into apache:master Sep 25, 2018
@sijie sijie deleted the bkperf branch September 25, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants