Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause #2553

Closed
wants to merge 1 commit into from

Conversation

dlg99
Copy link
Contributor

@dlg99 dlg99 commented Jan 26, 2021

DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause

Descriptions of the changes in this PR:

added .initCause for the new FNFE exception to preserver it

Motivation

got the
ERROR org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.RocksCheckpointer - Failed to restore rocksdb ...
java.io.FileNotFoundException: ..../metadata
without any additional info for the rootcause (other than stack pointing to the DLCheckpointStore)

DLCheckpointStore appears to re-throw exceptions as FNFE without preserving the rootcause

Changes

added .initCause

Master Issue: #2552


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

… rootcause; this complicates troubleshooting
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@eolivelli eolivelli closed this Jan 27, 2021
eolivelli pushed a commit that referenced this pull request Jan 28, 2021
… rootcause

DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause
Same as #2553 but for master branch

Descriptions of the changes in this PR:

added .initCause for the new FNFE exception to preserver it

### Motivation

got the
ERROR org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.RocksCheckpointer - Failed to restore rocksdb ...
java.io.FileNotFoundException: ..../metadata
without any additional info for the rootcause (other than stack pointing to the DLCheckpointStore)

DLCheckpointStore appears to re-throw exceptions as FNFE without preserving the rootcause

### Changes

added .initCause

Master Issue: #2552


Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2555 from dlg99/master-fnfe
eolivelli pushed a commit that referenced this pull request Jan 28, 2021
… rootcause

DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause
Same as #2553 but for master branch

Descriptions of the changes in this PR:

added .initCause for the new FNFE exception to preserver it

### Motivation

got the
ERROR org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.RocksCheckpointer - Failed to restore rocksdb ...
java.io.FileNotFoundException: ..../metadata
without any additional info for the rootcause (other than stack pointing to the DLCheckpointStore)

DLCheckpointStore appears to re-throw exceptions as FNFE without preserving the rootcause

### Changes

added .initCause

Master Issue: #2552

Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2555 from dlg99/master-fnfe

(cherry picked from commit bab5a00)
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
eolivelli pushed a commit that referenced this pull request Jan 28, 2021
… rootcause

DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause
Same as #2553 but for master branch

Descriptions of the changes in this PR:

added .initCause for the new FNFE exception to preserver it

### Motivation

got the
ERROR org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.RocksCheckpointer - Failed to restore rocksdb ...
java.io.FileNotFoundException: ..../metadata
without any additional info for the rootcause (other than stack pointing to the DLCheckpointStore)

DLCheckpointStore appears to re-throw exceptions as FNFE without preserving the rootcause

### Changes

added .initCause

Master Issue: #2552

Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2555 from dlg99/master-fnfe

(cherry picked from commit bab5a00)
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
eolivelli pushed a commit that referenced this pull request Jan 28, 2021
… rootcause

DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause
Same as #2553 but for master branch

Descriptions of the changes in this PR:

added .initCause for the new FNFE exception to preserver it

### Motivation

got the
ERROR org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.RocksCheckpointer - Failed to restore rocksdb ...
java.io.FileNotFoundException: ..../metadata
without any additional info for the rootcause (other than stack pointing to the DLCheckpointStore)

DLCheckpointStore appears to re-throw exceptions as FNFE without preserving the rootcause

### Changes

added .initCause

Master Issue: #2552

Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2555 from dlg99/master-fnfe

(cherry picked from commit bab5a00)
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
@dlg99 dlg99 deleted the branch-4.12-fnfe branch October 14, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants