-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause #2553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rootcause; this complicates troubleshooting
eolivelli
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
eolivelli
pushed a commit
that referenced
this pull request
Jan 28, 2021
… rootcause DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause Same as #2553 but for master branch Descriptions of the changes in this PR: added .initCause for the new FNFE exception to preserver it ### Motivation got the ERROR org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.RocksCheckpointer - Failed to restore rocksdb ... java.io.FileNotFoundException: ..../metadata without any additional info for the rootcause (other than stack pointing to the DLCheckpointStore) DLCheckpointStore appears to re-throw exceptions as FNFE without preserving the rootcause ### Changes added .initCause Master Issue: #2552 Reviewers: Enrico Olivelli <eolivelli@gmail.com> This closes #2555 from dlg99/master-fnfe
eolivelli
pushed a commit
that referenced
this pull request
Jan 28, 2021
… rootcause DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause Same as #2553 but for master branch Descriptions of the changes in this PR: added .initCause for the new FNFE exception to preserver it ### Motivation got the ERROR org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.RocksCheckpointer - Failed to restore rocksdb ... java.io.FileNotFoundException: ..../metadata without any additional info for the rootcause (other than stack pointing to the DLCheckpointStore) DLCheckpointStore appears to re-throw exceptions as FNFE without preserving the rootcause ### Changes added .initCause Master Issue: #2552 Reviewers: Enrico Olivelli <eolivelli@gmail.com> This closes #2555 from dlg99/master-fnfe (cherry picked from commit bab5a00) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
eolivelli
pushed a commit
that referenced
this pull request
Jan 28, 2021
… rootcause DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause Same as #2553 but for master branch Descriptions of the changes in this PR: added .initCause for the new FNFE exception to preserver it ### Motivation got the ERROR org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.RocksCheckpointer - Failed to restore rocksdb ... java.io.FileNotFoundException: ..../metadata without any additional info for the rootcause (other than stack pointing to the DLCheckpointStore) DLCheckpointStore appears to re-throw exceptions as FNFE without preserving the rootcause ### Changes added .initCause Master Issue: #2552 Reviewers: Enrico Olivelli <eolivelli@gmail.com> This closes #2555 from dlg99/master-fnfe (cherry picked from commit bab5a00) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
eolivelli
pushed a commit
that referenced
this pull request
Jan 28, 2021
… rootcause DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause Same as #2553 but for master branch Descriptions of the changes in this PR: added .initCause for the new FNFE exception to preserver it ### Motivation got the ERROR org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.RocksCheckpointer - Failed to restore rocksdb ... java.io.FileNotFoundException: ..../metadata without any additional info for the rootcause (other than stack pointing to the DLCheckpointStore) DLCheckpointStore appears to re-throw exceptions as FNFE without preserving the rootcause ### Changes added .initCause Master Issue: #2552 Reviewers: Enrico Olivelli <eolivelli@gmail.com> This closes #2555 from dlg99/master-fnfe (cherry picked from commit bab5a00) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause
Descriptions of the changes in this PR:
added .initCause for the new FNFE exception to preserver it
Motivation
got the
ERROR org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.RocksCheckpointer - Failed to restore rocksdb ...
java.io.FileNotFoundException: ..../metadata
without any additional info for the rootcause (other than stack pointing to the DLCheckpointStore)
DLCheckpointStore appears to re-throw exceptions as FNFE without preserving the rootcause
Changes
added .initCause
Master Issue: #2552