-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Netty to 4.1.86.Final #3669
Upgrade Netty to 4.1.86.Final #3669
Conversation
81d80b2
to
c9ceb44
Compare
@lhotari Thanks for your contribution, please take a look at the license check, thanks. |
Netty 4.1.85.Final upgrade causes a regression in Pulsar. I have commented on the Netty change about this: netty/netty#12888 (comment) . It seems that there is a major change in behavior in Netty's HashedWheelTimer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for Netty new release
c9ceb44
to
dd89aea
Compare
Upgraded to 4.1.86.Final which reverts the HashedWheelTimer change and includes some CVE fixes. See release notes for Netty changes. (referenced in PR description) |
Commands used to refresh licenses: cd bookkeeper-dist/src/main/resources/deps rm -rf netty-* mkdir netty-4.1.86.Final cd netty-4.1.86.Final curl -L -o - https://github.com/netty/netty/archive/refs/tags/netty-4.1.86.Final.tar.gz | tar -zxv --strip-components=2 --wildcards -f - '*/license/*' rm LICENSE.zstd-jni.txt LICENSE.brotli4j.txt cd .. git add netty-4.1.86.Final
ad747a4
to
5b8e96e
Compare
@hangc0276 Please re-review this PR and possibly also merge it. |
### Motivation - see release notes for 4.1.85.Final: https://netty.io/news/2022/11/09/4-1-85-Final.html - see release notes for 4.1.86.Final: https://netty.io/news/2022/12/12/4-1-86-Final.html It is unknown whether there are fixes that specifically target Netty features used in Bookkeeper. One of the motivation of this PR is to upgrade Netty in Bookkeeper when the Netty version gets upgraded in Pulsar. The PR for Netty 4.1.86.Final upgrade in Pulsar is apache/pulsar#18599 ### Changes Upgrade Netty version to 4.1.86.Final
### Motivation - see release notes for 4.1.85.Final: https://netty.io/news/2022/11/09/4-1-85-Final.html - see release notes for 4.1.86.Final: https://netty.io/news/2022/12/12/4-1-86-Final.html It is unknown whether there are fixes that specifically target Netty features used in Bookkeeper. One of the motivation of this PR is to upgrade Netty in Bookkeeper when the Netty version gets upgraded in Pulsar. The PR for Netty 4.1.86.Final upgrade in Pulsar is apache/pulsar#18599 ### Changes Upgrade Netty version to 4.1.86.Final
Motivation
It is unknown whether there are fixes that specifically target Netty features used in Bookkeeper. One of the motivation of this PR is to upgrade Netty in Bookkeeper when the Netty version gets upgraded in Pulsar. The PR for Netty 4.1.86.Final upgrade in Pulsar is apache/pulsar#18599
Changes
Upgrade Netty version to 4.1.86.Final