Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RegionAwareEnsemblePlacementPolicy.newEnsemble sometimes failed problem. #3725

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

horizonzy
Copy link
Member

@horizonzy horizonzy commented Jan 5, 2023

Descriptions of the changes in this PR:
Fixes #3722

Motivation

See #3722

@horizonzy horizonzy changed the title Fix newEnsemble sometimes failed problem. Fix RegionAwareEnsemblePlacementPolicy.newEnsemble sometimes failed problem. Jan 5, 2023
@horizonzy
Copy link
Member Author

rerun failure checks

Copy link
Member

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2023

Codecov Report

Merging #3725 (cbde227) into master (7f8c31b) will increase coverage by 0.06%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##             master    #3725      +/-   ##
============================================
+ Coverage     68.10%   68.17%   +0.06%     
- Complexity     6711     6714       +3     
============================================
  Files           473      473              
  Lines         40951    40952       +1     
  Branches       5235     5236       +1     
============================================
+ Hits          27890    27917      +27     
+ Misses        10806    10776      -30     
- Partials       2255     2259       +4     
Flag Coverage Δ
bookie 39.63% <0.00%> (-0.04%) ⬇️
client 44.28% <71.42%> (+0.03%) ⬆️
remaining 29.64% <42.85%> (+0.01%) ⬆️
replication 41.46% <14.28%> (+0.08%) ⬆️
tls 20.99% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...org/apache/bookkeeper/net/NetworkTopologyImpl.java 47.78% <33.33%> (ø)
...r/client/RackawareEnsemblePlacementPolicyImpl.java 82.20% <100.00%> (+0.21%) ⬆️
...r/client/ZoneawareEnsemblePlacementPolicyImpl.java 84.61% <100.00%> (ø)
...g/apache/bookkeeper/client/MetadataUpdateLoop.java 80.00% <0.00%> (-7.15%) ⬇️
.../java/org/apache/bookkeeper/bookie/SyncThread.java 69.69% <0.00%> (-3.04%) ⬇️
...g/apache/bookkeeper/meta/CleanupLedgerManager.java 71.00% <0.00%> (-2.00%) ⬇️
...apache/bookkeeper/verifier/BookkeeperVerifier.java 86.06% <0.00%> (-1.82%) ⬇️
...pache/bookkeeper/meta/zk/ZKMetadataDriverBase.java 60.71% <0.00%> (-0.72%) ⬇️
.../org/apache/bookkeeper/proto/BookieClientImpl.java 64.76% <0.00%> (-0.72%) ⬇️
...rg/apache/bookkeeper/bookie/IndexInMemPageMgr.java 87.25% <0.00%> (-0.39%) ⬇️
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hangc0276 hangc0276 merged commit 2381d9b into apache:master Feb 17, 2023
zymap pushed a commit that referenced this pull request Feb 21, 2023
…roblem. (#3725)

Descriptions of the changes in this PR:
Fixes #3722

### Motivation
See [#3722](#3722 (comment))

(cherry picked from commit 2381d9b)
hangc0276 pushed a commit to streamnative/bookkeeper-achieved that referenced this pull request Mar 28, 2023
…roblem. (apache#3725)

Descriptions of the changes in this PR:
Fixes apache#3722

### Motivation
See [apache#3722](apache#3722 (comment))

(cherry picked from commit 2381d9b)
hangc0276 pushed a commit to hangc0276/bookkeeper that referenced this pull request Jun 26, 2023
…roblem. (apache#3725)

Descriptions of the changes in this PR:
Fixes apache#3722

See [apache#3722](apache#3722 (comment))

(cherry picked from commit 2381d9b)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
…roblem. (apache#3725)

Descriptions of the changes in this PR:
Fixes apache#3722

### Motivation
See [apache#3722](apache#3722 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RackAware placement policy can not ensure new ensemble selection succeed when one rack goes down.
6 participants