Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] SingleDirectoryDbLedgerStorage#flushMutex does not release lock on all exception paths #3909

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

StevenLuMT
Copy link
Member

Descriptions of the changes in this PR:

Motivation

fix: #3908

Changes

  1. finally unlock SingleDirectoryDbLedgerStorage#flushMutex

Copy link
Contributor

@gaozhangmin gaozhangmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap cleanupExecutor.execute is better, Thx for pointing this out.

@hangc0276 hangc0276 added this to the 4.17.0 milestone Apr 7, 2023
@StevenLuMT StevenLuMT merged commit f1657ea into apache:master Apr 7, 2023
zymap pushed a commit that referenced this pull request Jun 19, 2023
… on all exception paths (#3909)

Co-authored-by: lushiji <lushiji@didiglobal.com>
(cherry picked from commit f1657ea)
hangc0276 pushed a commit to hangc0276/bookkeeper that referenced this pull request Jun 26, 2023
… on all exception paths (apache#3909)

Co-authored-by: lushiji <lushiji@didiglobal.com>
(cherry picked from commit f1657ea)
zymap pushed a commit that referenced this pull request Dec 6, 2023
… on all exception paths (#3909)

Co-authored-by: lushiji <lushiji@didiglobal.com>
(cherry picked from commit f1657ea)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
… on all exception paths (apache#3909)

Co-authored-by: lushiji <lushiji@didiglobal.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] SingleDirectoryDbLedgerStorage#flushMutex does not release lock on all exception paths
4 participants