Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop invalid entryFormat arg from shell command #3938

Merged
merged 1 commit into from
May 10, 2023
Merged

drop invalid entryFormat arg from shell command #3938

merged 1 commit into from
May 10, 2023

Conversation

wenbingshen
Copy link
Member

Motivation

According to the configuration of ENTRY_FORMATTER_CLASS in the bookkeeper shell command, it will never take effect, we should remove it,

We can use -entryformat or configure in bookie config to take effect.

@wenbingshen
Copy link
Member Author

rerun failure checks

@hangc0276 hangc0276 added this to the 4.17.0 milestone May 4, 2023
StevenLuMT
StevenLuMT requested changes May 10, 2023
View reviewed changes
Copy link
Member

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be compatibility issues, will it be compatible with old usage? i'm a bit worried about this

@wenbingshen
Copy link
Member Author

Will there be compatibility issues, will it be compatible with old usage? i'm a bit worried about this

@StevenLuMT I don't think there is an old compatibility issue here, because ENTRY_FORMATTER_CLASS is set as a jvm system property value, and It is not referenced anywhere in the bookkeeper's existing source code, even though the system the attribute has been configured, but it will not take effect. It is safe for us to delete it. PTAL. Thanks.

StevenLuMT
StevenLuMT approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@StevenLuMT StevenLuMT merged commit 551b2d5 into apache:master May 10, 2023
@wenbingshen wenbingshen deleted the wenbing/dropInvalidEntryFormat branch May 10, 2023 03:07
zymap pushed a commit that referenced this pull request Jun 19, 2023
@wenbingshen @zymap
drop invalid entryFormat arg from shell command (#3938)
8e8ea7a 
(cherry picked from commit 551b2d5)
zymap pushed a commit that referenced this pull request Dec 6, 2023
@wenbingshen @zymap
drop invalid entryFormat arg from shell command (#3938)
31e5d18 
(cherry picked from commit 551b2d5)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
@wenbingshen
drop invalid entryFormat arg from shell command (apache#3938)
5c0946a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangc0276 hangc0276 hangc0276 approved these changes

@shoothzj shoothzj shoothzj approved these changes

@StevenLuMT StevenLuMT StevenLuMT approved these changes

@eolivelli eolivelli Awaiting requested review from eolivelli

@zymap zymap Awaiting requested review from zymap

Assignees

@wenbingshen wenbingshen

Labels
area/tools cherry-picked/branch-4.15 cherry-picked/branch-4.16 release/4.15.5 release/4.16.2
Projects
None yet
Milestone
4.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wenbingshen @hangc0276 @shoothzj @StevenLuMT @zymap