Entry write support local node region aware placement policy #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested review from
merlimat,
dlg99,
eolivelli,
zymap,
wenbingshen and
StevenLuMT
|
@horizonzy Please help take a look at this PR, thanks. |
horizonzy
reviewed
Aug 30, 2023
| bookie9Count++; | ||
| } | ||
|
|
||
| LOG.info("[hangc] ensemble: {}", ensemble); |
| LOG.info("Bookie1 Count: {}, Bookie8 Count: {}, Bookie9 Count: {}", bookie1Count, bookie8Count, bookie9Count); | ||
|
|
||
| //addr4 shutdown. | ||
| addrs.remove(addr5.toBookieId()); |
There was a problem hiding this comment.
What's the purpose of this operation(remove addr5)
zymap
reviewed
Sep 1, 2023
| @@ -388,9 +388,20 @@ public PlacementResult<List<BookieId>> newEnsemble(int ensembleSize, int writeQu | |||
| remainingEnsembleBeforeIteration = remainingEnsemble; | |||
| int regionsToAllocate = numRemainingRegions; | |||
| int startRegionIndex = lastRegionIndex % numRegionsAvailable; | |||
| int localRegionIndex = -1; | |||
There was a problem hiding this comment.
Maybe a more clear way to do this is to remove the localRegion from the availableRegions then everything happen smoothly with original logic.
There was a problem hiding this comment.
Maybe not. If so, the localRegion node can't pick again. If we want to pick 5 nodes, and there are only two regions. If we remove localRegion, then we can only pick nodes from the remaining one region.
merlimat
approved these changes
Jan 5, 2024
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…4063) * Entry write support local node region aware placement policy * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The entry write supports the local node Rack-Aware placement policy but does not support the local node Region-Aware placement policy
The entry read supports the local node Region-Aware placement policy but does not support the local node Rack-Aware placement policy
In order to match the local node region/rack awareness both on entry write and read, we need to support the following feature
Entry write supports local node region awareness placement policy
Entry read supports local node rack awareness placement policy
Modification