Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ledgersCount.incrementAndGet in setExplicitLac function #4138

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Add ledgersCount.incrementAndGet in setExplicitLac function #4138

merged 1 commit into from
Dec 11, 2023

Conversation

liubingxing
Copy link
Contributor

@liubingxing liubingxing commented Nov 29, 2023 •
edited
Loading

The ledgersCount.incrementAndGet should be called in setExplicitLac , just like in setFenced and setLimbo.

@liubingxing liubingxing changed the title when setExplicitLac is called the ledgersCount should increased Add ledgersCount.incrementAndGet in setExplicitLac function Nov 29, 2023
eolivelli
eolivelli approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !
LGTM

@liubingxing
Copy link
Contributor Author

@eolivelli
It seem like that the failed test cases are not related to this PR.
image

@hangc0276 hangc0276 added this to the 4.17.0 milestone Dec 4, 2023
@hangc0276
Copy link
Contributor

@liubingxing Please rebase the master, thanks.

@liubingxing
Copy link
Contributor Author

@liubingxing Please rebase the master, thanks.

@hangc0276 Done it

@hangc0276
Copy link
Contributor

rerun failure checks

@hangc0276 hangc0276 merged commit 5be03cf into apache:master Dec 11, 2023
16 checks passed
yangl pushed a commit to yangl/bookkeeper that referenced this pull request Dec 11, 2023
@liubingxing @yangl
when setExplicitLac is called the ledgersCount should increased (apac…
2cd06b8 
…he#4138)

The **ledgersCount.incrementAndGet** should be called in **setExplicitLac** , just like in **setFenced** and **setLimbo**.
hangc0276 pushed a commit to hangc0276/bookkeeper that referenced this pull request Jan 18, 2024
@liubingxing @hangc0276
when setExplicitLac is called the ledgersCount should increased (apac…
15f764c 
…he#4138)

The **ledgersCount.incrementAndGet** should be called in **setExplicitLac** , just like in **setFenced** and **setLimbo**.

(cherry picked from commit 5be03cf)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
@liubingxing
when setExplicitLac is called the ledgersCount should increased (apac…
17b0f8e 
…he#4138)

The **ledgersCount.incrementAndGet** should be called in **setExplicitLac** , just like in **setFenced** and **setLimbo**.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangc0276 hangc0276 hangc0276 approved these changes

@eolivelli eolivelli eolivelli approved these changes

@wenbingshen wenbingshen wenbingshen approved these changes

Assignees

@liubingxing liubingxing

Labels
area/stats cherry-picked/branch-4.16 release/4.14.9 release/4.15.6 release/4.16.4
Projects
None yet
Milestone
4.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@liubingxing @hangc0276 @eolivelli @wenbingshen