Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 675: Enable checkstyle in a few packages #676

Closed
wants to merge 1 commit into from

Conversation

sijie
Copy link
Member

@sijie sijie commented Oct 27, 2017

These packages include:

  • feature
  • processor
  • shims
  • stats
  • streaming
  • versioning
  • zookeeper

not fully enabled in conf package.

These packages include:

- feature
- processor
- shims
- stats
- streaming
- versioning
- zookeeper

not fully enabled in conf package.
@sijie sijie added this to the 4.6.0 milestone Oct 27, 2017
@sijie sijie self-assigned this Oct 27, 2017
Copy link
Member

@jiazhai jiazhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, 👍 LGTM.
It is great to have check style enabled. Thanks for it.

@jiazhai jiazhai closed this in 502c6b1 Oct 29, 2017
test-things-on-github pushed a commit to test-things-on-github/bookkeeper that referenced this pull request Nov 2, 2017
These packages include:

- feature
- processor
- shims
- stats
- streaming
- versioning
- zookeeper

not fully enabled in conf package.

Author: Sijie Guo <sijie@apache.org>

Reviewers: Jia Zhai <None>

This closes apache#676 from sijie/fix_checkstyles, closes apache#675
@sijie sijie deleted the fix_checkstyles branch July 16, 2018 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants