Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated resteasy version #28

Merged
merged 2 commits into from
Sep 27, 2016

Conversation

Graeme-Miller
Copy link
Contributor

This is successor to this PR.
After the rest client was moved to brooklyn-client in this PR two new PRs had to be created, one for brooklyn-server and one for brooklyn-client.

Please merge this PR at the same time.

This PR updates resteasy to 3.0.14.Final.

@Graeme-Miller
Copy link
Contributor Author

Test failures are because brooklyn-client relies on brooklyn-rest-api which pulls in an older verision of jackson.

All tests pass locally when apache/brooklyn-server#339 is included.

@neykov
Copy link
Member

neykov commented Sep 21, 2016

@Graeme-Miller this change won't be needed if #27 is merged.

@aledsage
Copy link
Contributor

@Graeme-Miller Can you explain why we're upgrading to resteasy 3.0.14.Final? There is a 3.0.19.Final available - why not upgrade to that?


TL;DR we don't bundle brooklyn-rest-client with the Brooklyn distro, so I think we can ignore the version difference discussed below.

I see that resteasy depends on com.fasterxml.jackson version 2.6.3 (the previous resteasy resteasy 3.0.8 depended on fasterxml version 2.3.2).

However, in apache/brooklyn-server#339, you're upgrading com.fasterxml.jackson from 2.4.5 to 2.7.5. That means mvn is trying to pull in two different versions of fasterxml. That's manageable in Karaf (though not ideal), but is a pain with the vanilla Java main. We'd need to have <excludes> to ensure we get the right single version.

I see that resteasy has a 3.1.0.Beta2 available, which depends on fasterxml 2.7.4. It came out on 9th September 2016; the Beta1 was on 28th July 2016. That depends on fasterxml 2.7.4. It took 6 beta releases before a 3.0.0-rc1 and then 3.0.0.Final, so we shouldn't hold our breath!

@aledsage
Copy link
Contributor

LGTM. apache/brooklyn-server#339 is merged; merging this now.

@asfgit asfgit merged commit b6bfc5e into apache:master Sep 27, 2016
asfgit pushed a commit that referenced this pull request Sep 27, 2016
geomacy pushed a commit to geomacy/brooklyn-client that referenced this pull request Oct 11, 2016
…-more-consistent-part-2

Add error handling for entity related commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants