Issue with sslcheck flag #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a global flag and a command flag and both are not supported so now there's only a command flag Also updated to latest go, which had some knock-on effects.
duncangrant
commented
Mar 10, 2023
cli/app/app.go
Outdated
| //&cli.BoolFlag{ | ||
| // Name: "skipSslChecks", | ||
| // Usage: "Skip verification of server's certificate chain and hostname (for use with self-signed certs)", | ||
| //}, |
There was a problem hiding this comment.
I'll remove this
|
I've built this locally using go build and it fixes the flag issue however I can't get the docker build to work locally so I don't know how this will work in CI. It passes though so I guess it's ok. |
jcabrerizo
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Thanks for this @duncangrant. Updating the GO version has been on my todo list for a while
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a global flag and a command flag and both are not supported so now there's only a command flag
Also updated to latest go, which had some knock-on effects.