New periodic and scheduled effector policies #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grkvlt
force-pushed
the
feature/time-policies
branch
from
060d7d1
to
c549420
Compare
|
cool @grkvlt - wonder if you could do two things:
|
|
(yaml could be used in a test :nudge:) |
drigodwin
suggested changes
Sep 14, 2017
| * desiredSize: 1 | ||
| * period: 1 day | ||
| * time: 18:00:00 | ||
| * }</pre> |
There was a problem hiding this comment.
This example is for the ScheduledEffectorPolicy not the PeriodicEffectorPolicy
|
|
||
| @Override | ||
| public void rebind() { | ||
| // XXX Will the AtomicBoolean field be saved during rebind? |
There was a problem hiding this comment.
Probably resolve this question before merging...
|
I have added a PR for the documentation for this here. |
grkvlt
force-pushed
the
feature/time-policies
branch
4 times, most recently
from
156dee4
to
a5dff67
Compare
grkvlt
force-pushed
the
feature/time-policies
branch
from
a5dff67
to
00deb7d
Compare
grkvlt
force-pushed
the
feature/time-policies
branch
from
d47edce
to
0a71cf5
Compare
drigodwin
approved these changes
Sep 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds policies to execute effectors at specific times, either singly or repeated.