Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New periodic and scheduled effector policies #822

Merged
merged 2 commits into from
Sep 16, 2017

Conversation

grkvlt
Copy link
Member

@grkvlt grkvlt commented Sep 13, 2017

Adds policies to execute effectors at specific times, either singly or repeated.

@ahgittin
Copy link
Contributor

cool @grkvlt - wonder if you could do two things:

  • merge More on adjunct highlights #818 here for testing and follow the pattern there to set trigger and action highlights
  • include a YAML illustrating use of these policies

@ahgittin
Copy link
Contributor

(yaml could be used in a test :nudge:)

Copy link
Member

@drigodwin drigodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @grkvlt, thanks. Could really do with some tests.

* desiredSize: 1
* period: 1 day
* time: 18:00:00
* }</pre>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example is for the ScheduledEffectorPolicy not the PeriodicEffectorPolicy


@Override
public void rebind() {
// XXX Will the AtomicBoolean field be saved during rebind?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably resolve this question before merging...

@drigodwin
Copy link
Member

I have added a PR for the documentation for this here.

@grkvlt grkvlt force-pushed the feature/time-policies branch 4 times, most recently from 156dee4 to a5dff67 Compare September 15, 2017 10:28
@grkvlt
Copy link
Member Author

grkvlt commented Sep 15, 2017

@ahgittin I will do some testing of how this interacts with #818 but it will be in a separate PR so that this can get into the 0.12 RC

Copy link
Member

@drigodwin drigodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grkvlt

@asfgit asfgit merged commit 0a71cf5 into apache:master Sep 16, 2017
asfgit pushed a commit that referenced this pull request Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants