Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auto https check #1754

Merged
merged 1 commit into from
May 1, 2022
Merged

fix auto https check #1754

merged 1 commit into from
May 1, 2022

Conversation

renzhong
Copy link
Contributor

文章 文档中提到“Channel.Init能自动识别https”,相关功能在去年重构代码中引入了 bug,目前此功能已失效。这个 pt 是为了修复这个问题

@guodongxiaren
Copy link
Member

guodongxiaren commented Apr 30, 2022

感谢发现问题。不过空白符的修改不要提交了,这会让这个修复PR显得没那么干净,没办法快速聚焦到问题代码。
真正需要修改的只有两行代码而已。
请修改一下。

@guodongxiaren
Copy link
Member

@renzhong

@renzhong
Copy link
Contributor Author

renzhong commented May 1, 2022

已修改

@guodongxiaren guodongxiaren merged commit 2326f74 into apache:master May 1, 2022
@renzhong renzhong deleted the fix_https_check branch May 5, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants