-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macos workflow #1899
Merged
Merged
Macos workflow #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guodongxiaren
force-pushed
the
master
branch
2 times, most recently
from
August 28, 2022 08:59
e6ad969
to
4b7c660
Compare
#1657 was merged. |
单元测试在mac上也有失败case。 @zyearn |
看起来是slow test的问题,把expectation value改一下? |
@zyearn 改了以后还有其他地方失败。。。。 |
看了下主要是两个地方:
再改一改试试? |
目前有很多case是关于时间判断的,但macos执行过慢,可能会造成这些case非常不稳定,要不先跳过mac上的ut执行?先把mac编译加到CI里 |
可以。我晚点改一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will close #1842
目前有两个小问题。一个是bazel无法构建,需要rework bazel的那个PR合入。#1657
另外一个是macos上test_bvar的UT失败,这个已经提了issue介绍 : #1897