Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macos workflow #1899

Merged
merged 5 commits into from
Oct 30, 2022
Merged

Macos workflow #1899

merged 5 commits into from
Oct 30, 2022

Conversation

guodongxiaren
Copy link
Member

@guodongxiaren guodongxiaren commented Aug 20, 2022

will close #1842

目前有两个小问题。一个是bazel无法构建,需要rework bazel的那个PR合入。#1657
另外一个是macos上test_bvar的UT失败,这个已经提了issue介绍 : #1897

@zyearn
Copy link
Member

zyearn commented Aug 31, 2022

#1657 was merged.

@guodongxiaren
Copy link
Member Author

单元测试在mac上也有失败case。 @zyearn

@zyearn
Copy link
Member

zyearn commented Oct 25, 2022

[ RUN      ] RecorderTest.latency_recorder_qps_accuracy
bvar_recorder_unittest.cpp:240: Failure
Expected: (0.1) > (read(lr1, 10/2.0)), actual: 0.1 vs 0.191

看起来是slow test的问题,把expectation value改一下?

@guodongxiaren
Copy link
Member Author

@zyearn 改了以后还有其他地方失败。。。。

@zyearn
Copy link
Member

zyearn commented Oct 26, 2022

看了下主要是两个地方:

I1026 15:17:31  5891 bthread_butex_unittest.cpp:61] Joined thread 4294969088 at 232338us [0]
Expected: (labs(elp - (th - (bthread_t*)arg + 1) * 100000L)) <= (15000L), actual: 131917 vs 15000
bthread_butex_unittest.cpp:59: Failure
Expected: (labs(elp - (th - (bthread_t*)arg + 1) * 100000L)) <= (15000L), actual: 65739 vs 15000

再改一改试试?

@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 27, 2022

目前有很多case是关于时间判断的,但macos执行过慢,可能会造成这些case非常不稳定,要不先跳过mac上的ut执行?先把mac编译加到CI里
后面可能需要系统地理一下这些case

@guodongxiaren
Copy link
Member Author

目前有很多case是关于时间判断的,但macos执行过慢,可能会造成这些case非常不稳定,要不先跳过mac上的ut执行?先把mac编译加到CI里

后面可能需要系统地理一下这些case

可以。我晚点改一下

@guodongxiaren
Copy link
Member Author

把uinitest和mac 的bazel编译都删掉了 @zyearn @wwbmmm

@zyearn zyearn merged commit 96c690a into apache:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate MacOS compilation into github actions
3 participants