Support all compile options and unittest for Linux workflow #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* all opt * Update ci_linux.yml * Update ci_linux.yml * Update ci_linux.yml * Update ci_linux.yml * Update ci_linux.yml * action * fix * fix * all-dep * fix * Update action.yml * fix run * all-opt * core * core * init-make-config * opt * config brpc * fix * rm deafult
guodongxiaren
changed the title
我记得这个是并发编译的时候protoc还在执行，但引用idl_options.pb.h已经需要前一步的结果了，这里应该需要加一个编译顺序 |
|
install-all-dependences 和 install-dependences 的区别是all包含非必要的依赖，可以换个名字比如：
然后all版本引用essential的文件而不是再写一份，不清楚这个在yml文件里能不能实现？ |
|
@zyearn 修改了，有空看下 |
|
赞，之后提个PR把老的travis删掉应该就好了 |
|
以及github主页上的build link应该要改成指向Actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #1963
Problem Summary:
What is changed and the side effects?
Changed:
针对make编译，额外调用一次protoc来处理mcpack2pb中的proto，因为make的编译不稳定，经常报错Makefile修复，避免mcpack编译失败src/mcpack2pb/generator.cpp:30:10: fatal error: idl_options.pb.h: No such file or directorySide effects:
Check List: