Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selective_channle支持返回response_attachment #2329

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

yockie
Copy link
Contributor

@yockie yockie commented Jul 25, 2023

What problem does this PR solve?

测试发现,channel类型是selective_channel时client收不到server填充的response_attachment。

@wwbmmm
Copy link
Contributor

wwbmmm commented Jul 26, 2023

LGTM

2 similar comments
@chenBright
Copy link
Contributor

LGTM

@serverglen
Copy link
Contributor

LGTM

@wwbmmm wwbmmm merged commit d72d320 into apache:master Aug 16, 2023
16 checks passed
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
Co-authored-by: yuncheng <yuncheng@pinduoduo.com>
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
Co-authored-by: yuncheng <yuncheng@pinduoduo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants