Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast show socket map in vars #2376

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

chenBright
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

尽快创建_this_map_bvar,便于调试。

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Contributor

wwbmmm commented Sep 19, 2023

如果为了尽快创建_this_map_bvar,是不是在SocketMap构造的时候就创建?

@chenBright
Copy link
Contributor Author

FLAGS_show_socketmap_in_vars支持在内置服务页面动态打开的,所以此前的实现需要在Insert、Remove函数里创建吧

@wwbmmm
Copy link
Contributor

wwbmmm commented Sep 22, 2023

FLAGS_show_socketmap_in_vars支持在内置服务页面动态打开的,所以此前的实现需要在Insert、Remove函数里创建吧

如果这样是不是可以在Insert、Remove的入口处加这个逻辑,感觉不用改动那么多代码

@chenBright
Copy link
Contributor Author

可以,已经在Insert、Remove的入口处加这个逻辑。

@wwbmmm
Copy link
Contributor

wwbmmm commented Sep 26, 2023

LGTM

@chenBright
Copy link
Contributor Author

没有其他问题的话,这个PR应该可以合了

@serverglen
Copy link
Contributor

LGTM

@serverglen serverglen merged commit 72036f1 into apache:master Oct 11, 2023
16 checks passed
@chenBright chenBright deleted the socket_map_bvar branch October 11, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants