Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rpc protobuf message factory interface #2718

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

chenBright
Copy link
Contributor

What problem does this PR solve?

Issue Number: resolve #2671

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright chenBright force-pushed the rpc_pb_factory branch 2 times, most recently from f288129 to e20d804 Compare July 30, 2024 03:21
@wwbmmm
Copy link
Contributor

wwbmmm commented Aug 8, 2024

LGTM

Copy link
Contributor

@oathdruid oathdruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenBright
Copy link
Contributor Author

chenBright commented Aug 21, 2024

  1. 用户一般不会创建很多server,所以不需要全局的DefaultRpcPBMessageFactory,每个server new一个DefaultRpcPBMessageFactory即可。这样,可以简化一些逻辑。
  2. 更新server中文文档。

@wwbmmm wwbmmm merged commit 48996cf into apache:master Aug 26, 2024
20 checks passed
@chenBright chenBright deleted the rpc_pb_factory branch August 26, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support arena allocation for server mode in native protocol
3 participants