Use butil::AlignedMemory instead of std::aligned_storage to align memory for placement new #2719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2288 中引入用于对齐
Element
地址的std::aligned_storage
在C++23中已经被废弃了。详细背景见P1413R3提案。Problem Summary:
What is changed and the side effects?
Changed:
C++17起,使用P1413R3提案中建议的alignas(T) std::byte element_spaces[sizeof(T)]
来代替std::aligned_storage
。butil::AlignedMemory
的实现跟P1413R3提案中建议的alignas(T) std::byte[sizeof(T)]
类似,优点是封装性更好,所以使用butil::ManualConstructor
(包含butil::AlignedMemory
)代替std::aligned_storage
。MPSCQueueNode
、ObjectPool
、ResourcePool
也需要对齐。ALIGNAS
宏的一些注释(来自于chromium)。Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: