[CALCITE-4617] Wrong offset when SortJoinTransposeRule pushes a sort node with an offset #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrozon
changed the title
|
Would it be possible to have a unit test "showing" the error? (i.e. the test returns an incorrect result with current code, and correct result with the patch) |
vlsi
reviewed
May 24, 2021
|
LGTM |
rubenada
added
the
LGTM-will-merge-soon
|
@scrozon as discussed in the Jira, could you please provide more unit tests for this rule? |
rubenada
removed
the
LGTM-will-merge-soon
scrozon
commented
May 29, 2021
core/src/main/java/org/apache/calcite/rel/rules/SortJoinTransposeRule.java
Outdated
Show resolved
Hide resolved
…fset twice (Sylvain Crozon) the added sorted shouldn't re-apply offset, otherwise we end up skipping rows twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sort node added on top of the join shouldn't re-apply the offset of the original sort node, otherwise we end up skipping rows twice