[CALCITE-5191] Allow sort by alias in BigQuery #2833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenruimeng
changed the title
chunweilei
added
the
LGTM-will-merge-soon
|
Oops. I didn't notice that the commit message is wrong. |
|
I have force-pushed the main branch to fix the commit message. Closed by fa65a2e. |
|
@chunweilei Thanks for merging this change. |
julianhyde
added a commit
to julianhyde/calcite
that referenced
this pull request
Jun 20, 2022
Use ORDER BY rather than sort by in commit message. Revert static include of SqlConformanceEnum.BIG_QUERY, which is inconsistent with other conformance constants in the same file, and introduces unnecessary cosmetic changes. Switch cases are in alphabetical order. Correct javadoc. Generalize test, and add javadoc. Close apache#2833
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Jun 20, 2022
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Jun 20, 2022
aymeric-dispa
pushed a commit
to aymeric-dispa/calcite
that referenced
this pull request
Jul 23, 2022
tanclary
pushed a commit
to tanclary/calcite
that referenced
this pull request
Nov 11, 2022
tanclary
pushed a commit
to tanclary/calcite
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.