-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CALCITE-3329] Implement osquery for OS adapter #3585
Conversation
adf185b
to
94110de
Compare
94110de
to
258b8a8
Compare
FileSystem fileSystem = OshiUtil.getOs().getFileSystem(); | ||
List<OSFileStore> fileStores = fileSystem.getFileStores(); | ||
for (OSFileStore fileStore : fileStores) { | ||
Object[] objects = new Object[8]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer
Object[] objects = {
fileStore.getName(),
fileStore.getName(),
getNetFileSizeDescription(fileStore.getTotalSpace()),
...
};
Without explicit length and offset it is more maintainable.
@@ -64,6 +64,10 @@ public class SqlShell { | |||
this.err = Objects.requireNonNull(err, "err"); | |||
} | |||
|
|||
public static void setModel(String newModel) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really need to be mutable?
Could you achieve what you need with a withModel(String model)
method?
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 9 New issues |
Close apache#3585
Fix ISSUE CALCITE-3329, Achieve similar features of FaceBook's osquery. E.g: