[CALCITE-6063] If ARRAY subquery has ORDER BY (without LIMIT), rows are not sorted #3644
Conversation
chucheng92
force-pushed
the
CALCITE-6063
branch
from
1e3dfb4
to
23099a6
Compare
|
| @@ -5538,7 +5538,7 @@ ImmutableList<RelNode> retrieveCursors() { | |||
| case ARRAY_QUERY_CONSTRUCTOR: | |||
| call = (SqlCall) expr; | |||
| query = Iterables.getOnlyElement(call.getOperandList()); | |||
| root = convertQueryRecursive(query, false, null); | |||
| root = convertQueryRecursive(query, true, null); | |||
There was a problem hiding this comment.
I think this deserves a comment. I think you are pretending this to be the toplevel query, because this will prevent ORDER BY from being eliminated.
There was a problem hiding this comment.
Agree. Perhaps rename boolean top to boolean preserveOrderBy (assuming that top doesn't control any other behavior). Then the documentation can be on the convertQueryRecursive method.
There was a problem hiding this comment.
thanks, fixed. however I still used top, The current codepath is passed in from top all the way. top is also easy to understand.
There was a problem hiding this comment.
You force-pushed?!
Sorry, I know the rules for review, but I accidentally force-push it ..
site/_docs/reference.md
Outdated
|
|
||
| | Operator syntax | Description | | ||
| |:-----------------------------------|:------------| | ||
| | ARRAY (sub-query) | Creates an array from the result of a sub-query. Example: `ARRAY(SELECT empno FROM emp)` | |
There was a problem hiding this comment.
maybe add ORDER BY to example, to illustrate that it is possible
chucheng92
changed the title
chucheng92
force-pushed
the
CALCITE-6063
branch
2 times, most recently
from
8c978fc
to
0265ec5
Compare
chucheng92
force-pushed
the
CALCITE-6063
branch
from
0265ec5
to
de9a0fa
Compare
|
I have updated the PR to fix:
It should be noted that there are some differences between ARRAY subquery and MULTISET/MAP subquery. Please refer to the comments of the CALCITE-6063 for details. We may decide to make some improvements in follow-up issues or PRs. |
chucheng92
changed the title
|
Hi guys. Sorry, I accidentally forced-push PR instead of a new commit, but there are no new lines affecting the logic, only the test cases for map/multiset. If there are no other comments, I will merge it later. Thanks for reviewing it! |
|
merging... |
issue:
https://issues.apache.org/jira/browse/CALCITE-6063
context:
The sql-standard-2003 allows array constrcutor by query:
and calcite does support it.
however the orderby was removed by the issue https://issues.apache.org/jira/browse/CALCITE-2978.
The solution of this PR is same as #1763 to allow sort in subquery.