[CALCITE-6224] Add LOG2 function (enabled in Mysql, Spark library) #3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added tanclary as a co-author, maybe I am not qualified to be called the author. |
caicancai
force-pushed
the
help-caican-6224
branch
from
7e20eff
to
1fd3daf
Compare
tanclary
approved these changes
Feb 28, 2024
JiajunBernoulli
approved these changes
Feb 28, 2024
|
LGTM |
|
Please squash them, we can merge it soon. |
caicancai
force-pushed
the
help-caican-6224
branch
from
1fd3daf
to
6ca5416
Compare
done |
|
@caicancai I just squashed and merged you should find the commit in the main branch now, thanks! |
@tanclary I am very grateful for your help in this PR. I will soon improve the log function of mysql. Action is the best feedback. |
|
github-actions bot
pushed a commit
to macroguo-ghy/calcite
that referenced
this pull request
Mar 4, 2024
Co-authored-by: Tanner Clary <tannerclary@google.com> close apache#3707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.