Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support explicit source/target in knative endpoint #150

Closed
nicolaferraro opened this issue Oct 9, 2019 · 3 comments · Fixed by #153
Closed

Support explicit source/target in knative endpoint #150

nicolaferraro opened this issue Oct 9, 2019 · 3 comments · Fixed by #153
Assignees

Comments

@nicolaferraro
Copy link
Member

Currently Camel K 1.0.0-M2 has a pre-baked list of allowed endpoints that can be used as start or end of a route.

E.g.

from('knative:channel/xx`)

The Knative trait looks for:

  • eventing.knative.dev/v1alpha1 -> Channel
  • messaging.knative.dev/v1alpha1 -> Channel
  • messaging.knative.dev/v1alpha1 -> InMemoryChannel
  • messaging.knative.dev/v1alpha1 -> KafkaChannel
  • ...

A similar thing happen for the knative/endpoint.

It would be better if a user can explicitly set the target, like:

from('knative:channel/xx?kind=InMemoryChannel')

or even:

from('knative:channel/xx?kind=InMemoryChannel&apiVersion=messaging.knative.dev/v1')

Same also for endpoint. In the case of channel, the operator creates also a subscription.

The resolution of the apiVersion and kind will happen at operator level, but those properties need to be accepted by the runtime.

Wdyt @lburgazzoli ?

@lburgazzoli
Copy link
Contributor

A simple solution would be to make the endpoint to allow unknown options, would that be ok ?

@lburgazzoli lburgazzoli self-assigned this Oct 9, 2019
@nicolaferraro
Copy link
Member Author

Not sure.. I'm worried about @valdar making typos at next conference and not getting an error back :)

@lburgazzoli
Copy link
Contributor

So I will add such info even if we throw them away :)

lburgazzoli added a commit to lburgazzoli/apache-camel-k-runtime that referenced this issue Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants