Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kamelet entry in catalog #492

Closed
nicolaferraro opened this issue Sep 22, 2020 · 1 comment · Fixed by #494
Closed

Fix kamelet entry in catalog #492

nicolaferraro opened this issue Sep 22, 2020 · 1 comment · Fixed by #494
Assignees
@lburgazzoli
Labels
kind/bug Something isn't working
Milestone
1.5.0

Comments

@nicolaferraro
Copy link
Member 

    camel-kamelet:
      groupId: org.apache.camel.k
      artifactId: camel-kamelet
      schemes:
      - id: kamelet
        http: true
        passive: false
      dependencies:
      - groupId: org.apache.camel.k
        artifactId: camel-k-quarkus-kamelet

I think it should be marked as http=false, passive=true (like a passive endpoint, which has no effect on the trait processing). Then the operator will determine the actual type by looking at the kamelet code.
@nicolaferraro nicolaferraro added the kind/bug Something isn't working label Sep 22, 2020
@nicolaferraro nicolaferraro added this to the 1.5.0 milestone Sep 22, 2020
@nicolaferraro
Copy link
Member Author

Otherwise a kamelet:timer to log ends up being a Knative service.

@lburgazzoli lburgazzoli self-assigned this Sep 22, 2020
lburgazzoli added a commit to lburgazzoli/apache-camel-k-runtime that referenced this issue Sep 22, 2020
@lburgazzoli
Fix kamelet entry in catalog apache#492
b516a2f
@lburgazzoli lburgazzoli mentioned this issue Sep 22, 2020
Merged
lburgazzoli added a commit that referenced this issue Sep 22, 2020
@lburgazzoli
Fix kamelet entry in catalog #492
ba00c3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lburgazzoli lburgazzoli

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Fix kamelet entry in catalog lburgazzoli/apache-camel-k-runtime
2 participants
@lburgazzoli @nicolaferraro