Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime health endpoint #22

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Add runtime health endpoint #22

merged 1 commit into from
Mar 1, 2019

Conversation

lburgazzoli
Copy link
Contributor

Fixes #21

@lburgazzoli lburgazzoli force-pushed the github-21 branch 3 times, most recently from 0142427 to 3438c8a Compare February 28, 2019 22:45
nicolaferraro
nicolaferraro approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok. I forsee issues when trying to add this to the camel k workflow. E.g. base images won't be used because an additional dependency is needed... Wdyt?

nicolaferraro
nicolaferraro reviewed Feb 28, 2019
View reviewed changes
camel-k-runtime-health/src/main/java/org/apache/camel/k/health/HealthEndpoint.java
if (!Objects.equals(path, msg.uri())) {
status = HttpResponseStatus.NOT_FOUND;
content = Unpooled.wrappedBuffer(KO);
} else if (context.getStatus() == ServiceStatus.Started) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true when routes are down for master-component/routepolicy?

Copy link
Contributor Author

@lburgazzoli lburgazzoli Feb 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, context is always running, only the consumer part of the route is stopped

@lburgazzoli
Copy link
Contributor Author

Seems ok. I forsee issues when trying to add this to the camel k workflow. E.g. base images won't be used because an additional dependency is needed... Wdyt?

We may need to add an option to the publisher to configure additional dependencies

@lburgazzoli
Copy link
Contributor Author

@nicolaferraro what is not yet implemented is the integration with camel health's subsystem will do in a future pr

@lburgazzoli lburgazzoli merged commit 6f58877 into apache:master Mar 1, 2019
@lburgazzoli lburgazzoli deleted the github-21 branch March 1, 2019 06:59
@nicolaferraro nicolaferraro mentioned this pull request Mar 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lburgazzoli @nicolaferraro @oscerd