Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add a binding sub command #2083

Closed
lburgazzoli opened this issue Mar 2, 2021 · 4 comments · Fixed by #2183
Closed

cli: add a binding sub command #2083

lburgazzoli opened this issue Mar 2, 2021 · 4 comments · Fixed by #2183
Assignees
Labels
area/cli Kamel CLI
Milestone

Comments

@lburgazzoli
Copy link
Contributor

lburgazzoli commented Mar 2, 2021

We should have a kamel subcommand to create KameltBinding, something like:

kamelet bind --from=telegram-text-source --to=my-topic@kafka.strimzi.io/v1beta1:KafkaTopic 

Things to take into account:

  • how to properly bind properties to a kamelet, when it is used multiple times
@lburgazzoli lburgazzoli added the area/cli Kamel CLI label Mar 2, 2021
@astefanutti astefanutti changed the title cli: ad a binding sub command cli: add a binding sub command Mar 2, 2021
@nicolaferraro nicolaferraro added this to the 1.4.0 milestone Mar 2, 2021
@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented Mar 9, 2021

Thinking a little bit more, we can also add options to define intermediate steps and error handling, like:

kamelet bind 
	--from=telegram-text-source 
    --step=log-action
    --step=filter-action
    --to=my-topic@kafka.strimzi.io/v1beta1:KafkaTopic
    --error-handler=my-error-handler

@heiko-braun
Copy link

What about --steps=[one,two, three, ...] (ordered list)?

@heiko-braun
Copy link

heiko-braun commented Mar 29, 2021

Also, will we have kamel rebind at some point? (similar to redeploy) Asking for a friend who wonders how updates to bindings are performed

@nicolaferraro
Copy link
Member

So, the impl in #2183 does a redeploy by default in case of matching binding name (which is computed after the bound resources, or it can be passed as --name arg).
The CLI has a nice sintax for multiple steps that is like:

--step kamelet1 --step kamelet2

They are kept sorted. The problem is when kamelet1 has a required parameter... how do we specify it?

nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Apr 7, 2021
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Apr 7, 2021
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Apr 8, 2021
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Apr 8, 2021
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Apr 9, 2021
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Apr 9, 2021
nicolaferraro added a commit that referenced this issue Apr 12, 2021
squakez pushed a commit to squakez/camel-k that referenced this issue Apr 13, 2021
squakez pushed a commit to squakez/camel-k that referenced this issue Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Kamel CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants