Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2083: add kamel bind command #2183

Merged
merged 6 commits into from
Apr 12, 2021

Conversation

nicolaferraro
Copy link
Member

Fix #2083

This works, but I'm looking for better ways..

Current syntax is like:

# Unqualified references default to "kamelet:"
kamel bind telegram-source broker:default -p source.authorizationToken=xxx
# Bound elements can also be full refs and Camel URIs
kamel bind kafka.strimzi.io/v1beta1:KafkaTopic:test log:info

So there's a single "-p" option with properties that need to be prefixed with source. or sink..
This avoid having to define e.g. --source-property and --sink-property, which is the other option I've considered.

But both approaches fail when it comes for steps. It's easy to add a --step to add other endpoints, but how to specify their related properties? Like: -p step-0.prefix=World -p step-1.prefix=Hello?

Release Note

NONE

@nicolaferraro nicolaferraro added the status/wip Work in progress label Mar 29, 2021
@lburgazzoli
Copy link
Contributor

lburgazzoli commented Mar 29, 2021

Wonder if they can be considered somehow as URI

kamel bind telegram-source?options broker:default?options --step step1?options

we can use something like

 ?id=test

to define the properties prefix ?

@nicolaferraro nicolaferraro merged commit ca0bcad into apache:master Apr 12, 2021
@nicolaferraro nicolaferraro deleted the kamel-bind branch April 12, 2021 13:56
@nicolaferraro nicolaferraro mentioned this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: add a binding sub command
3 participants