Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SourceSpec Type default to empty #2223

Closed
squakez opened this issue Apr 15, 2021 · 3 comments · Fixed by apache/camel-k-runtime#685
Closed

SourceSpec Type default to empty #2223

squakez opened this issue Apr 15, 2021 · 3 comments · Fixed by apache/camel-k-runtime#685

Comments

@squakez
Copy link
Contributor

squakez commented Apr 15, 2021

This is a follow up of this PR comment. As reported in camel-k-runtime, we may experience some issue because the value of SourceSpec type is default to empty in several parts of Camel K. We assume that empty value to be a source type on the runtime.

Should we enforce the SourceType to a value instead? I think it would be cleaner.

cc @lburgazzoli @astefanutti @nicolaferraro
@lburgazzoli
Copy link
Contributor

can we set the default value on runtime ?

@squakez
Copy link
Contributor Author

squakez commented Apr 15, 2021

can we set the default value on runtime ?

I think we can. Does that mean that we assume that a default values is always a source type?

@lburgazzoli
Copy link
Contributor

I'm fine with that

squakez added a commit to squakez/camel-k-runtime that referenced this issue May 25, 2021
@squakez
fix(core): default SourceType as source
d04f0ca 
Setting any empty SourceType as a source.

Closes apache#658
Closes apache/camel-k#2223
@squakez squakez mentioned this issue May 25, 2021
Merged
lburgazzoli pushed a commit to apache/camel-k-runtime that referenced this issue Jun 10, 2021
@squakez @lburgazzoli
fix(core): default SourceType as source
db0c960 
Setting any empty SourceType as a source.

Closes #658
Closes apache/camel-k#2223
orpiske pushed a commit to orpiske/camel-k-runtime that referenced this issue Jun 18, 2021
@squakez @orpiske
fix(core): default SourceType as source
d83f2fe 
Setting any empty SourceType as a source.

Closes apache#658
Closes apache/camel-k#2223
orpiske pushed a commit to apache/camel-k-runtime that referenced this issue Jun 18, 2021
@squakez @orpiske
fix(core): default SourceType as source
bcd5de9 
Setting any empty SourceType as a source.

Closes #658
Closes apache/camel-k#2223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): default SourceType as source squakez/camel-k-runtime
2 participants
@lburgazzoli @squakez