Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monitoring): Migrate to PodMonitor for Integration monitoring #2216

Merged
merged 5 commits into from
Apr 15, 2021
Merged

feat(monitoring): Migrate to PodMonitor for Integration monitoring #2216

merged 5 commits into from
Apr 15, 2021

Conversation

astefanutti
Copy link
Member

@astefanutti astefanutti commented Apr 13, 2021

Fixes #1555.
Fixes #2212.

Tested compatibility with Knative, and OpenShift monitoring stack, using the feed, splitter, printer example:

Screenshot 2021-04-13 at 18 56 24

Release Note

feat(monitoring): Migrate to PodMonitor for Integration monitoring

@astefanutti astefanutti changed the title feat(monitoring): Migrate to PodMonitor in Prometheus trait feat(monitoring): Migrate to PodMonitor for Integration monitoring Apr 14, 2021
@nicolaferraro nicolaferraro added the kind/feature New feature or request label Apr 15, 2021
@nicolaferraro
Copy link
Member

May there be a general issue in the runtime? I see a NullPointerException in the logs

@astefanutti
Copy link
Member Author

May there be a general issue in the runtime? I see a NullPointerException in the logs

Yes, it seems there is another issue with the polyglot tests, as well as the OpenAPI ones. It may relate to apache/camel-k-runtime#658.

@squakez would you be able to have a look, it seems for these tests, the source type may be null.

@astefanutti
Copy link
Member Author

Let me merge this as the remaining CI errors are not related.

@astefanutti astefanutti merged commit 189f862 into apache:master Apr 15, 2021
@astefanutti astefanutti deleted the pr-235 branch April 15, 2021 11:54
@squakez
Copy link
Contributor

squakez commented Apr 15, 2021

May there be a general issue in the runtime? I see a NullPointerException in the logs

Yes, it seems there is another issue with the polyglot tests, as well as the OpenAPI ones. It may relate to apache/camel-k-runtime#658.

@squakez would you be able to have a look, it seems for these tests, the source type may be null.

Yes, I planned to work on it soon.

squakez added a commit to squakez/camel-k-runtime that referenced this pull request Apr 15, 2021
squakez added a commit to squakez/camel-k-runtime that referenced this pull request Apr 15, 2021
@squakez
Copy link
Contributor

squakez commented Apr 15, 2021

We have too many places where we just don't set the SourceType right now in the code. For the OpenAPI, for example it's here but I've found a few more. I've provided a defensive solution for the time being in order to avoid any possible NPE but I think we need a more devised solution.

I think we should understand if we want always to set the SourceType and hence enforce it in all parts of the code here in Camel K.

I will better follow up with a separate issue.

@astefanutti
Copy link
Member Author

The tactical solution sounds indeed safer as we are releasing 1.4.0. Once it's out, one approach is to set the type field as required in the Integration CRD, possibly adding the list of possible values, and fix the places where it's missing.

nicolaferraro pushed a commit to apache/camel-k-runtime that referenced this pull request Apr 15, 2021
orpiske pushed a commit to apache/camel-k-runtime that referenced this pull request May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
4 participants