Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kamel local chokes on traits #2499

Closed
pilhuhn opened this issue Jul 13, 2021 · 4 comments · Fixed by #3034
Closed

Kamel local chokes on traits #2499

pilhuhn opened this issue Jul 13, 2021 · 4 comments · Fixed by #3034
Assignees
Labels
area/cli Kamel CLI area/ux Improves user experience

Comments

@pilhuhn
Copy link

pilhuhn commented Jul 13, 2021

Kamel run supports traits via modline or -t flag.
The local build/run fails with them.

Local option should not fail -- especially if the trait is needed for in-cluster execution and given via modline

% kamel version
Camel K Client 1.5.0
hrupp@snert cdi % kamel local build c-tower.yml
Modeline options have been loaded from source files
Full command: kamel local build c-tower.yml --trait=knative.channel-sinks=return-channel --dependency=mvn:com.github.pilhuhn:camel-ansible-tower:95bd0a70da --dependency=mvn:org.apache.camel.k:camel-k-knative-producer
Error: unknown flag: --trait

Same for kamel local run

@pilhuhn pilhuhn changed the title Kamel local chokes on traits Kamel local chokes on traits Jul 13, 2021
@tadayosi
Copy link
Member

It's related to #2490. At this moment it's not clear what we can expect from kamel local run.

My feeling with this issue, however, is that it doesn't make sense to support traits with local run, as traits are mainly for adapting remote platform differences, not local.

@pilhuhn
Copy link
Author

pilhuhn commented Jul 14, 2021

My issue is that I have the traits in the modline. Removing them from there means I will later forget to add them in remote mode.
If they make no sense locally, a warning could be printed, but kamel local build should not abort.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@scodeman
Copy link

This issue should not be closed, as mentionned by @pilhuhn, the local build could print a warning but not abort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Kamel CLI area/ux Improves user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants