Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kamel bind step index unclear #2586

Closed
squakez opened this issue Aug 23, 2021 · 9 comments · Fixed by #3884
Closed

Kamel bind step index unclear #2586

squakez opened this issue Aug 23, 2021 · 9 comments · Fixed by #3884
Labels
area/ux Improves user experience good first issue Does not require full understanding of the codebase status/never-stale

Comments

@squakez
Copy link
Contributor

squakez commented Aug 23, 2021

I was playing with kamel bind command and I realized that we use 0 index start when we play with step properties. Ie kamel bind ... --step my-step -p step-0.my-key=value. For usability I think we should improve this and let the user start with 1 index instead.

@squakez squakez added the area/ux Improves user experience label Aug 23, 2021
@heiko-braun
Copy link

+1

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@squakez squakez added the good first issue Does not require full understanding of the codebase label Feb 15, 2022
@SaumyaSachdev
Copy link

Hi, I'm an Outreachy applicant and I'd like to be assigned this issue

@squakez
Copy link
Contributor Author

squakez commented Apr 18, 2022

Thanks for the interest. Please, reach out to me if you need any help.

@SaumyaSachdev
Copy link

Hi @squakez, I tried reaching out to you on Zulip with a few questions. Could you please help with them?

@squakez
Copy link
Contributor Author

squakez commented Apr 19, 2022

Hello, I've already answered in the chat, though, it's easier for me following up here asynchronously. As a reference you can used the output produced by the following statement:

$ kamel bind timer:foo log:bar --step first --step second -p step-0.var1=1 -p step-0.var2=2 -p step-1.vara=a -o yaml

We must convert that index starting with 0 to start with 1 and having the very same output. Likely a unit test as the one available at https://github.com/apache/camel-k/blob/main/pkg/cmd/bind_test.go#L61 will help you making some good TDD approach.

@SaumyaSachdev
Copy link

makeError
I'm trying to test my changes locally by building the repository and replacing the binary in my /usr/bin, however, I get this error. I was successfully able to build this project earlier. Could you please help resolve this error? I'm not sure what is wrong here

@squakez
Copy link
Contributor Author

squakez commented Apr 19, 2022

Yeah, this one will fix the problem: #3222

In the while, you can temporary change that value manually on your makefile, and then, revert before committing, so it won't conflict during merge.

@essobedo
Copy link
Contributor

@SaumyaSachdev are you still working on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux Improves user experience good first issue Does not require full understanding of the codebase status/never-stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants